aws/session: Adding support for credential_source #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibz
force-pushed
the
2005
branch
4 times, most recently
from
19c9027 to
8bfe2ca
Compare
xibz
force-pushed
the
2005
branch
3 times, most recently
from
73f7744 to
48b8168
Compare
…Metadata, and Environment
jasdel
suggested changes
Oct 11, 2018
| @@ -1,5 +1,5 @@ | |||
| [default] | |||
| s3 = | |||
| s3 = | |||
There was a problem hiding this comment.
don't think this file actually changed?
There was a problem hiding this comment.
removes unneeded whitespace
aws/session/shared_config.go
Outdated
| @@ -127,6 +129,11 @@ func loadSharedConfigIniFiles(filenames []string) ([]sharedConfigFile, error) { | |||
| func (cfg *sharedConfig) setAssumeRoleSource(origProfile string, files []sharedConfigFile) error { | |||
| var assumeRoleSrc sharedConfig | |||
|
|
|||
| if len(cfg.AssumeRole.CredentialSource) > 0 { | |||
| cfg.AssumeRoleSource = &sharedConfig{} | |||
There was a problem hiding this comment.
Could you document why this check is for.
jasdel
approved these changes
Oct 11, 2018
This was referenced Oct 12, 2018
Merged
rickard-von-essen
added a commit
to rickard-von-essen/packer
that referenced
this pull request
Oct 15, 2018
This adds support for credential_source, see aws/aws-sdk-go#2201 Closes hashicorp#6717
This was referenced Oct 18, 2018
q3aiml
pushed a commit
to q3aiml/chamber
that referenced
this pull request
Jan 15, 2019
Picking up support for credential_source. This allows assuming a role while using profile creds from ec2 instance metadata: aws/aws-sdk-go#2201.
nickatsegment
pushed a commit
to segmentio/chamber
that referenced
this pull request
Jan 18, 2019
Picking up support for credential_source. This allows assuming a role while using profile creds from ec2 instance metadata: aws/aws-sdk-go#2201.
|
This issue also fixed #1019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credential_source is a value supported by other SDKs to allow users to dictate where credentials are retrieved. The valid values for credential_source are
EcsContainer,Ec2InstanceMetadata, andEnvironment.#2005